OK - so your comment prompted me to look at this more closely.
It turns out I am using a folder portal - but when I double click on a folder short cut in the folder portal window:
On my old machine (the functionality I want)
the short cut opens in a new window
On my new machine (the functionality I do not want)
the short cut opens in the folder portal window.
Help!